CLI | Add threshold user input validation (AST-40169) #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Policy Management Violations
No New Or Fixed Issues Found |
internal/commands/scan.go
Outdated
| func parseThresholdLimit(limit string) (engineName string, intLimit int, err error) { | ||
| parts := strings.Split(limit, "=") | ||
| engineName = strings.Replace(parts[0], commonParams.KicsType, commonParams.IacType, 1) | ||
| if len(parts) > 1 { |
There was a problem hiding this comment.
You can reduce Cyclomatic Complexity if you invert the condition:
if len(parts) <= 1
{
return engineName, intLimit, err
}
and later the logic you currently have inside len(parts) > 1
internal/commands/scan.go
Outdated
| } | ||
|
|
||
| func normalizeThresholds(threshold string) string { | ||
| return strings.ReplaceAll(strings.ReplaceAll(threshold, " ", ""), ",", ";") |
There was a problem hiding this comment.
Suggestion:
any chance to make it more readable?
OrShamirCM
reviewed
Apr 28, 2024
OrShamirCM
reviewed
Apr 28, 2024
OrShamirCM
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Add threshold user input validation
References
https://checkmarx.atlassian.net/browse/AST-40169
Testing
Checklist